kishoreg commented on a change in pull request #4956: Make plugin manager to
load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362986701
##########
File path: pinot-tools/pom.xml
##########
@@ -165,6 +163,7 @@
<extraArguments>
<extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
<extraArgument>-Dlog4j2.configurationFile=conf/pinot-tools-log4j2.xml</extraArgument>
+ <extraArgument>-Dplugins.dir=plugins</extraArgument>
Review comment:
can we make it absolute? I think there is a variable set in the script to
get the basedir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
