snleee commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571359606 @icefury71 Current implementation adds a generic API that can add arbitrary `tags` on `instance` (there's no check on `newTag`). I think that this is why @mcvsubbu mentioned that we are probably adding the same API that Helix already provides. We currently use Helix's tag mostly for tenant assignment but it's possible that we will use these tags for other features (e.g. multiple tags for multiple features for an instance). In that case, this API can start to become complex since it will have to include all the validations for different tag usages. Instead, I think that it's better to provide very specific API on `/tenants` and limit its functionality to add/remove instances to/from a tenant and not to touch other tags. I can think of something like the following: ``` List the instances that belong to a tenant (this already exists) GET /tenant/{tenantName} Add an instance to a tenant POST /tenant/{tenantName}/{instanceName}?type=offline/realtime/broker Delete an instance from a tenant DELETE /tenant/{tenantName}/{instanceName} ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
