Jackie-Jiang commented on a change in pull request #4952: Adding new Controller
APIs for retrieving and setting tag for an instance
URL: https://github.com/apache/incubator-pinot/pull/4952#discussion_r363991317
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java
##########
@@ -176,4 +177,68 @@ public SuccessResponse dropInstance(
}
return new SuccessResponse("Successfully dropped instance");
}
-}
+
+ @GET
+ @Path("/instances/{instanceName}/tags")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Get all the tags for the specified instance",
produces = MediaType.APPLICATION_JSON)
+ @ApiResponses(value = {@ApiResponse(code = 200, message = "Success"),
@ApiResponse(code = 404, message = "Instance not found"), @ApiResponse(code =
500, message = "Internal error")})
+ public String getInstanceTags(
Review comment:
IMO `getInstance()` is good enough for this purpose, no need to add another
one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
