mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363552150
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java
##########
@@ -57,6 +58,13 @@
*/
Set<String> getPhysicalColumnNames();
+ /**
+ * Returns all columns for the "select *" query
+ *
+ * @return Set of column names
+ */
+ Set<String> getColumnNamesForSelectStar();
Review comment:
We have two APIs, one named getColumnNames() and the other named
getPhysicalColumnNames(). select * should decide which one to use? Do we need
a third one? Why can't getPhysicalColumnNames API return the right set of
columns from the consuming segment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
