haibow commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363561268
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java
##########
@@ -57,6 +58,13 @@
*/
Set<String> getPhysicalColumnNames();
+ /**
+ * Returns all columns for the "select *" query
+ *
+ * @return Set of column names
+ */
+ Set<String> getColumnNamesForSelectStar();
Review comment:
For the consuming segment, `select *` should return physical columns + newly
added columns. Since the newly added columns are provided by the virtual column
provider, I feel it a bit weird to include them in getPhysicalColumnNames
method.
Basically the columns are
1. physical column
2. virtual column
2.1 built-in virtual columns (docId, segmentName, hostName)
2.2 newly added columns in the consuming segment
`getColumnNames` should return 1+2.1+2.2
`getPhysicalColumnNames` should return 1
`getColumnNamesForSelectStar` should return 1+2.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
