kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963#discussion_r363616977
########## File path: pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-base/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java ########## @@ -36,14 +36,14 @@ import org.apache.commons.configuration.MapConfiguration; import org.apache.commons.io.FileUtils; import org.apache.commons.io.IOUtils; +import org.apache.pinot.plugin.ingestion.batch.common.Constants; Review comment: we should ideally move these to spi. I will do this in another PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
