fx19880617 commented on a change in pull request #4963: Package rename 
pinot-plugin modules (part of #4941).
URL: https://github.com/apache/incubator-pinot/pull/4963#discussion_r363860386
 
 

 ##########
 File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReaderFactory.java
 ##########
 @@ -33,18 +33,18 @@
   private static final Map<String, String> 
DEFAULT_RECORD_READER_CONFIG_CLASS_MAP = new HashMap<>();
 
   // TODO: This could be removed once we have dynamic loading plugins supports.
 
 Review comment:
   This requires PluginManager to populate this map, by setting fileFormat and 
classname when loading each input format plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to