grcevski commented on a change in pull request #4933: Fix benchmark client
URL: https://github.com/apache/incubator-pinot/pull/4933#discussion_r365327846
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -259,7 +259,7 @@ public HelixAdmin getHelixAdmin() {
private void addInstanceGroupTagIfNeeded() {
InstanceConfig instanceConfig = getHelixInstanceConfig(_instanceId);
assert instanceConfig != null;
- if (!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
+ if (instanceConfig != null &&
!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
Review comment:
Hey @mcvsubbu, no problem at all, I was away as well for the holidays :).
Here's a stack trace we see (apologies for the formatting) :
Exception caught:
java.lang.NullPointerException: null
at
org.apache.pinot.controller.helix.core.PinotHelixResourceManager.addInstanceGroupTagIfNeeded(PinotHelixResourceManager.java:262)
~[pinot-controller-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.controller.helix.core.PinotHelixResourceManager.start(PinotHelixResourceManager.java:189)
~[pinot-controller-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.perf.PerfBenchmarkDriver.startHelixResourceManager(PerfBenchmarkDriver.java:258)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.perf.PerfBenchmarkDriver.run(PerfBenchmarkDriver.java:172)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.perf.PerfBenchmarkRunner.startServerWithPreLoadedSegments(PerfBenchmarkRunner.java:122)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.perf.PerfBenchmarkRunner.execute(PerfBenchmarkRunner.java:99)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.PinotToolLauncher.execute(PinotToolLauncher.java:58)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
at
org.apache.pinot.tools.PinotToolLauncher.main(PinotToolLauncher.java:69)
~[pinot-tools-0.3.0-SNAPSHOT.jar:0.3.0-SNAPSHOT-63ceb0c47759cf5b7372c03a2d76f7206bbec133]
The command line I'm running the benchmark server with is:
pinot-tools.sh PerfBenchmarkRunner -mode startAll -dataDir
temp/optimal_startree_small_yearly -tableNames tpch_lineitem_OFFLINE
Thanks a bunch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
