grcevski commented on a change in pull request #4933: Fix benchmark client
URL: https://github.com/apache/incubator-pinot/pull/4933#discussion_r372006792
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -259,7 +259,7 @@ public HelixAdmin getHelixAdmin() {
private void addInstanceGroupTagIfNeeded() {
InstanceConfig instanceConfig = getHelixInstanceConfig(_instanceId);
assert instanceConfig != null;
- if (!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
+ if (instanceConfig != null &&
!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
Review comment:
Sorry again about the rebase issue @mcvsubbu. I've cleaned up the branch and
it correctly shows the 3 changes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
