mcvsubbu commented on a change in pull request #4993: Support Text column type
in Pinot (both offline and realtime)
URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r369169551
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -118,6 +131,54 @@
private volatile long _lastIndexedTimeMs = Long.MIN_VALUE;
private volatile long _latestIngestionTimeMs = Long.MIN_VALUE;
+ private static final ScheduledExecutorService _scheduledExecutorService;
+ private static final
ConcurrentLinkedQueue<RealtimeLuceneReadersForRealtimeSegment>
_luceneRealtimeReaders;
+ private static final ConcurrentHashMap<String,
RealtimeLuceneReadersForRealtimeSegment> _segmentToRealtimeLuceneReadersMap;
+
+ static {
Review comment:
As discussed, it needs to be either an instance per table or a singleton
instance across all tables. Best to create a class and add functionality to it.
We can wire it in later depending on what else we decide (e.g. per table config
to control the knob of consistency vs overhead)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
