vincentchenjl commented on a change in pull request #5009: [TE] auto enable
data-availaibity trigger for PINOT detections withou…
URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r370381169
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java
##########
@@ -530,6 +535,11 @@ private DetectionConfigDTO
generateDetectionConfig(Map<String, Object> yamlConfi
config.setActive(MapUtils.getBooleanValue(yamlConfigMap, PROP_ACTIVE,
true));
config.setYaml(yamlConfig);
+ //TODO: data-availability trigger is only enabled for detections running
on PINOT only
Review comment:
Ideally, data availability trigger should be enabled if the cron is
specified. However, due to the current prod setup, we only get events for Pinot
dataset. We should remove the check for Pinot dataset when we get update events
for other data source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
