vincentchenjl commented on a change in pull request #5009: [TE] auto enable
data-availaibity trigger for PINOT detections withou…
URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r371521380
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java
##########
@@ -530,6 +535,11 @@ private DetectionConfigDTO
generateDetectionConfig(Map<String, Object> yamlConfi
config.setActive(MapUtils.getBooleanValue(yamlConfigMap, PROP_ACTIVE,
true));
config.setYaml(yamlConfig);
+ //TODO: data-availability trigger is only enabled for detections running
on PINOT only
+ if (MapUtils.getString(yamlConfigMap, PROP_CRON) == null
+ && datasetConfigs.stream().allMatch(c ->
c.getDataSource().equals(PinotThirdEyeDataSource.DATA_SOURCE_NAME))) {
Review comment:
Added the check for the granularity of dataset. Even if the detection is a
weekly detection, it can be data-availability triggered as long as it is daily
Pinot dataset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
