siddharthteotia commented on a change in pull request #5014: fixing converting
PinotQuery to BrokerRequest for group by clause with selections
URL: https://github.com/apache/incubator-pinot/pull/5014#discussion_r370770689
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -92,6 +94,34 @@ public static PinotQuery compileToPinotQuery(String sql)
return pinotQuery;
}
+ static void validate(PinotQuery pinotQuery)
+ throws SqlCompilationException {
+ // Sanity check group by query: All identifiers in selection list should
be also included in group by list.
Review comment:
I don't think we should support function expressions part of GROUP BY
clause. See example here
https://github.com/apache/incubator-pinot/pull/5014#discussion_r370769811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
