chenboat commented on a change in pull request #4914: [POC] By-passing
deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r378470584
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -396,7 +398,7 @@ public String
segmentCommitEndWithMetadata(@QueryParam(SegmentCompletionProtocol
requestParams.withInstanceId(instanceId).withSegmentName(segmentName).withOffset(offset)
.withSegmentLocation(segmentLocation).withSegmentSizeBytes(segmentSizeBytes)
.withBuildTimeMillis(buildTimeMillis).withWaitTimeMillis(waitTimeMillis).withNumRows(numRows)
- .withMemoryUsedBytes(memoryUsedBytes);
+
.withMemoryUsedBytes(memoryUsedBytes).withSegmentUploadToController(segmentUpload);
Review comment:
The getUrl() of the SegmentCompletionProtocol.Request method has been
updated to include the new parameter (i.e., _segmentUploadToController). The
default value is true. So my understanding is that the URL construction for
Pinot servers have been taken care of. Am I missing anything?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
