chenboat commented on a change in pull request #4914: [POC] By-passing
deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r378582257
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -396,7 +398,7 @@ public String
segmentCommitEndWithMetadata(@QueryParam(SegmentCompletionProtocol
requestParams.withInstanceId(instanceId).withSegmentName(segmentName).withOffset(offset)
.withSegmentLocation(segmentLocation).withSegmentSizeBytes(segmentSizeBytes)
.withBuildTimeMillis(buildTimeMillis).withWaitTimeMillis(waitTimeMillis).withNumRows(numRows)
- .withMemoryUsedBytes(memoryUsedBytes);
+
.withMemoryUsedBytes(memoryUsedBytes).withSegmentUploadToController(segmentUpload);
Review comment:
Good point. I guess this is related to the change in the
updateCommittingSegmentZKMetadata() to:
committingSegmentZKMetadata.setDownloadUrl(committingSegmentDescriptor.getSegmentLocation());
In the current code, the Download URL is essentially hardcoded to the
vip-base url. With my change, I also need to update the segmentLocation in
committingSegmentDescriptor after the segment is moved from tmp location to
permanent location during a split-commit. Then the above change should work in
all cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
