codecov-io commented on issue #5066: Refactor existing Message Handler to update query quota on broker URL: https://github.com/apache/incubator-pinot/pull/5066#issuecomment-585420144 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=h1) Report > Merging [#5066](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/bfa176ce6f44b6d859b15baa1eab5c071cc37ddc?src=pr&el=desc) will **increase** coverage by `7.98%`. > The diff coverage is `55.17%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5066 +/- ## ============================================ + Coverage 50.43% 58.42% +7.98% Complexity 12 12 ============================================ Files 1185 1185 Lines 63441 63465 +24 Branches 9325 9325 ============================================ + Hits 31997 37079 +5082 + Misses 28948 23665 -5283 - Partials 2496 2721 +225 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ot/common/messages/TimeboundaryRefreshMessage.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvVGltZWJvdW5kYXJ5UmVmcmVzaE1lc3NhZ2UuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==) | `66.85% <0%> (-2.34%)` | `0 <0> (ø)` | | | [...oker/broker/helix/BrokerMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlck1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `67.69% <56.66%> (ø)` | `0 <0> (?)` | | | [...er/starter/helix/SegmentMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `69.33% <57.14%> (+69.33%)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `70.58% <87.5%> (+1.5%)` | `0 <0> (ø)` | :arrow_down: | | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `88.01% <0%> (+0.46%)` | `0% <0%> (ø)` | :arrow_down: | | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.8% <0%> (+0.72%)` | `0% <0%> (ø)` | :arrow_down: | | [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `86.87% <0%> (+0.77%)` | `0% <0%> (ø)` | :arrow_down: | | [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `70.63% <0%> (+0.85%)` | `0% <0%> (ø)` | :arrow_down: | | [.../FixedByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5TaW5nbGVWYWx1ZVJlYWRlcldyaXRlci5qYXZh) | `98.94% <0%> (+1.05%)` | `0% <0%> (ø)` | :arrow_down: | | ... and [303 more](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=footer). Last update [bfa176c...b6e49a0](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
