mcvsubbu commented on a change in pull request #5066: Refactor existing Message
Handler to update query quota on broker (Part 1)
URL: https://github.com/apache/incubator-pinot/pull/5066#discussion_r379594722
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentMessageHandlerFactory.java
##########
@@ -88,7 +88,9 @@ public MessageHandler createHandler(Message message,
NotificationContext context
case SegmentReloadMessage.RELOAD_SEGMENT_MSG_SUB_TYPE:
return new SegmentReloadMessageHandler(new
SegmentReloadMessage(message), _metrics, context);
default:
- throw new UnsupportedOperationException("Unsupported user defined
message sub type: " + msgSubType);
+ LOGGER.error("Unsupported user defined message sub type: {} for
segment: {}", msgSubType,
Review comment:
change this to warning and log it in the deafult message handler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
