codecov-io edited a comment on issue #5066: Refactor existing Message Handler to update query quota on broker (Part 1) URL: https://github.com/apache/incubator-pinot/pull/5066#issuecomment-585420144 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=h1) Report > Merging [#5066](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/bfa176ce6f44b6d859b15baa1eab5c071cc37ddc?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `36.23%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5066 +/- ## ============================================ - Coverage 50.43% 50.39% -0.05% Complexity 12 12 ============================================ Files 1185 1209 +24 Lines 63441 64533 +1092 Branches 9325 9482 +157 ============================================ + Hits 31997 32521 +524 - Misses 28948 29479 +531 - Partials 2496 2533 +37 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `59.07% <ø> (+0.28%)` | `0 <0> (ø)` | :arrow_down: | | [...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==) | `66.85% <0%> (-2.34%)` | `0 <0> (ø)` | | | [...er/starter/helix/SegmentMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/common/messages/QueryQuotaUpdateMessage.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvUXVlcnlRdW90YVVwZGF0ZU1lc3NhZ2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...oker/broker/helix/BrokerMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlck1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `65.67% <56.25%> (ø)` | `0 <0> (?)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `69.28% <87.5%> (+0.2%)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/pinot/common/config/RoutingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JvdXRpbmdDb25maWcuamF2YQ==) | `70% <0%> (-13.34%)` | `0% <0%> (ø)` | | | [...pache/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NvcnRlZFJhbmdlSW50ZXJzZWN0aW9uLmphdmE=) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | | | [.../startree/v2/builder/OffHeapSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL09mZkhlYXBTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `87.34% <0%> (-4.22%)` | `0% <0%> (ø)` | | | [...mpl/invertedindex/RealtimeInvertedIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVJbnZlcnRlZEluZGV4UmVhZGVyLmphdmE=) | `95.83% <0%> (-4.17%)` | `0% <0%> (ø)` | | | ... and [63 more](https://codecov.io/gh/apache/incubator-pinot/pull/5066/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=footer). Last update [bfa176c...330a83a](https://codecov.io/gh/apache/incubator-pinot/pull/5066?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
