snleee commented on issue #5083: Add test for supporting no dictionary on variable width columns in realtime segments URL: https://github.com/apache/incubator-pinot/pull/5083#issuecomment-588559346 @mcvsubbu 's comment is based on the following code. `LLRealtimeSegmentDataManager:consumeLoop()` The below code is outside of the main loop. We need to move that block into the main loop in order to emit the metrics correctly. ``` if (_numRowsErrored > 0) { _serverMetrics.addMeteredTableValue(_metricKeyName, ServerMeter.ROWS_WITH_ERRORS, _numRowsErrored); _serverMetrics.addMeteredTableValue(_tableStreamName, ServerMeter.ROWS_WITH_ERRORS, _numRowsErrored); } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
