mcvsubbu commented on issue #5083: Add test for supporting no dictionary on variable width columns in realtime segments URL: https://github.com/apache/incubator-pinot/pull/5083#issuecomment-588563318 There is more to it than meets the eye. We dont want to just move this into the loop, Instead, we should emit the metrics if we are extending the consumption time and there were errors. Let us think about this a bit more. I think it is outside the loop for a reason.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
