siddharthteotia commented on a change in pull request #5082: Plug in the new routing introduced in #5046 URL: https://github.com/apache/incubator-pinot/pull/5082#discussion_r382739530
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java ########## @@ -82,16 +82,16 @@ private ZkHelixPropertyStore<ZNRecord> _propertyStore; private HelixDataAccessor _helixDataAccessor; - // Cluster change handlers - private HelixExternalViewBasedRouting _helixExternalViewBasedRouting; Review comment: It looks like with these changes we can delete HelixExternalViewBasedRouting class and RoutingTable interface? (assuming RoutingManager is backward compatible) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
