siddharthteotia commented on a change in pull request #5082: Plug in the new routing introduced in #5046 URL: https://github.com/apache/incubator-pinot/pull/5082#discussion_r382755312
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java ########## @@ -23,77 +23,96 @@ import io.swagger.annotations.ApiParam; import io.swagger.annotations.ApiResponse; import io.swagger.annotations.ApiResponses; +import java.util.List; +import java.util.Map; +import java.util.TreeMap; import javax.inject.Inject; import javax.ws.rs.GET; import javax.ws.rs.Path; import javax.ws.rs.PathParam; import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; import javax.ws.rs.WebApplicationException; import javax.ws.rs.core.MediaType; import javax.ws.rs.core.Response; -import org.apache.pinot.broker.routing.RoutingTable; -import org.apache.pinot.broker.routing.TimeBoundaryService; +import org.apache.pinot.broker.routing.v2.RoutingManager; +import org.apache.pinot.broker.routing.v2.timeboundary.TimeBoundaryInfo; import org.apache.pinot.common.config.TableNameBuilder; -import org.apache.pinot.common.metrics.BrokerMeter; -import org.apache.pinot.common.metrics.BrokerMetrics; -import org.apache.pinot.common.utils.CommonConstants; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import org.apache.pinot.common.utils.CommonConstants.Helix.TableType; +import org.apache.pinot.core.transport.ServerInstance; +import org.apache.pinot.pql.parsers.Pql2Compiler; Review comment: I generally like the REST API resources to document in the javadoc each API endpoint and purpose as bullet list. But upto you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
