siddharthteotia commented on a change in pull request #5074: Support segment
reload for text index
URL: https://github.com/apache/incubator-pinot/pull/5074#discussion_r382871960
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/V3DefaultColumnHandler.java
##########
@@ -61,21 +63,27 @@ protected void updateDefaultColumn(String column,
DefaultColumnAction action)
"Default value indices for column: " + column + " cannot be removed
for V3 format segment.");
}
- // Create new dictionary and forward index, and update column metadata
- createColumnV1Indices(column);
Review comment:
This is existing behavior (I mean not changed as part of this PR. Github
doesn't do a good job of recognizing even little bit of code movement ).
I noticed this as well. I am not sure why we do this. Can look into it
separately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
