mcvsubbu commented on a change in pull request #5074: Support segment reload
for text index
URL: https://github.com/apache/incubator-pinot/pull/5074#discussion_r382879463
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/V1Constants.java
##########
@@ -103,6 +103,7 @@
public static final String PARTITION_VALUES = "partitionValues";
public static final String DATETIME_FORMAT = "datetimeFormat";
public static final String DATETIME_GRANULARITY = "datetimeGranularity";
+ public static final String HAS_TEXT_INDEX = "hasTextIndex";
Review comment:
Why not just have text index type instead of a boolean _and_ the type? we
can have an enum NONE to represent no text index, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
