mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r384861889
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -155,27 +155,37 @@ public void updateDefaultColumns()
*
* @return Action Map for each column.
*/
- private Map<String, DefaultColumnAction> computeDefaultColumnActionMap() {
+ public static Map<String, DefaultColumnAction>
computeDefaultColumnActionMap(Schema schema,
Review comment:
Not sure if we still need to modify this class. It should remain the same
for the completed segments, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
