mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r384860001
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java
##########
@@ -83,7 +83,11 @@ private void extractColumnsAndTransforms(BrokerRequest
brokerRequest, IndexSegme
// Extract selection expressions
List<String> selectionColumns = selection.getSelectionColumns();
if (selectionColumns.size() == 1 && selectionColumns.get(0).equals("*"))
{
- for (String column : indexSegment.getPhysicalColumnNames()) {
+ for (String column : indexSegment.getColumnNames()) {
Review comment:
we can just get physical column names, right? Are we trying to say that
virtual columns that do not start with dollar sign are ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
