mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r387396744
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -125,6 +128,9 @@ private volatile long _latestIngestionTimeMs = Long.MIN_VALUE; private RealtimeLuceneReaders _realtimeLuceneReaders; + // If the table schema is changed before the consuming segment is committed, newly added columns would appear in _newlyAddedColumnsFieldMap. + private volatile Map<String, FieldSpec> _newlyAddedColumnsFieldMap = new ConcurrentHashMap(); + private volatile Map<String, ColumnProvider> _newlyAddedColumnsProviderMap = new ConcurrentHashMap<>(); Review comment: You don't need volatile. You never set these values again in the class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
