mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r387398515
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -546,19 +561,32 @@ public SegmentMetadata getSegmentMetadata() {
for (FieldSpec fieldSpec : _physicalFieldSpecs) {
physicalColumnNames.add(fieldSpec.getName());
}
-
- return physicalColumnNames;
+ // We should include newly added columns in the physical columns
Review comment:
What if newly introduced column is a virtual column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
