mayankshriv commented on a change in pull request #5118: Synthetic Time Series 
Generator for pinot-tools
URL: https://github.com/apache/incubator-pinot/pull/5118#discussion_r388625495
 
 

 ##########
 File path: 
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/DataGenerator.java
 ##########
 @@ -100,6 +110,23 @@ public void generate(long totalDocs, int numFiles)
     }
   }
 
+  public void generateCsv(long totalDocs, int numFiles)
+      throws IOException {
+    final int numPerFiles = (int) (totalDocs / numFiles);
+    for (int i = 0; i < numFiles; i++) {
+      try (FileWriter writer = new FileWriter(outDir + "/output.csv")) {
 
 Review comment:
   Output file name should come from cli?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to