mayankshriv commented on a change in pull request #5118: Synthetic Time Series
Generator for pinot-tools
URL: https://github.com/apache/incubator-pinot/pull/5118#discussion_r388625912
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/DataGeneratorSpec.java
##########
@@ -47,17 +48,19 @@
private final boolean overrideOutDir;
public DataGeneratorSpec() {
- this(new ArrayList<String>(), new HashMap<String, Integer>(), new
HashMap<String, IntRange>(),
- new HashMap<String, DataType>(), new HashMap<String, FieldType>(), new
HashMap<String, TimeUnit>(),
+ this(new ArrayList<String>(), new HashMap<>(), new HashMap<>(), new
HashMap<>(),
+ new HashMap<>(), new HashMap<>(), new HashMap<>(),
Review comment:
`System.getProperty("java.io.tmpdir")` instead of `/tmp`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
