Jackie-Jiang commented on a change in pull request #4954: Support schema
evolution for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r390002075
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -164,16 +164,16 @@ public void updateDefaultColumns(IndexLoadingConfig
indexLoadingConfig)
*
* @return Action Map for each column.
*/
- private Map<String, DefaultColumnAction> computeDefaultColumnActionMap() {
+ static Map<String, DefaultColumnAction> computeDefaultColumnActionMap(Schema
schema, SegmentMetadataImpl segmentMetadata) {
Review comment:
Can we revert this as well? Seems only used in the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
