Jackie-Jiang commented on a change in pull request #4954: Support schema
evolution for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r389913141
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/reader/impl/SortedIndexMultiValueReader.java
##########
@@ -16,13 +16,32 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.core.segment.virtualcolumn;
+package org.apache.pinot.core.io.reader.impl;
+
+import java.io.IOException;
+import org.apache.pinot.common.utils.Pairs;
+import org.apache.pinot.core.io.reader.ReaderContext;
+import org.apache.pinot.core.io.reader.SingleColumnMultiValueReader;
+import org.apache.pinot.core.segment.index.readers.InvertedIndexReader;
+
/**
- * Provide the default null value as a single string.
+ * Interface for sorted index multi-value readers.
*/
-public class DefaultNullValueSingleStringVirtualColumnProvider extends
SingleStringVirtualColumnProvider {
- protected String getValue(VirtualColumnContext context) {
- return context.getFieldSpec().getDefaultNullValue().toString();
- }
+public interface SortedIndexMultiValueReader<T extends ReaderContext> extends
SingleColumnMultiValueReader<T>, InvertedIndexReader<Pairs.IntPair> {
Review comment:
Please remove this as multi-value column can never be sorted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
