Jackie-Jiang commented on a change in pull request #5163: Optimization for
selection only queries: Allow early termination
URL: https://github.com/apache/incubator-pinot/pull/5163#discussion_r394074020
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/BaseSingleValueQueriesTest.java
##########
@@ -121,8 +122,14 @@ public void loadSegment()
throws Exception {
ImmutableSegment immutableSegment = ImmutableSegmentLoader.load(new
File(INDEX_DIR, SEGMENT_NAME), ReadMode.heap);
_indexSegment = immutableSegment;
- _segmentDataManagers = Arrays
- .asList(new ImmutableSegmentDataManager(immutableSegment), new
ImmutableSegmentDataManager(immutableSegment));
+ _segmentDataManagers = new ArrayList<>();
+ for (int i = 0; i< getNumSegmentDataManagers(); i++) {
Review comment:
(nit) please reformat and cache `getNumSegmentDataManagers()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
