Jackie-Jiang commented on a change in pull request #5163: Optimization for
selection only queries: Allow early termination
URL: https://github.com/apache/incubator-pinot/pull/5163#discussion_r394071927
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/CombineOperator.java
##########
@@ -196,6 +202,17 @@ public IntermediateResultsBlock callJob()
return mergedBlock;
}
+ // This will check if IntermediateResultsBlock already satisfying query, so
there is no need to continue query processing.
+ private boolean allowEarlyTermination(BrokerRequest brokerRequest,
IntermediateResultsBlock mergedBlock) {
Review comment:
Can we rename this method to something more intuitive? Like
`isQuerySatisfied()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
