Jackie-Jiang commented on a change in pull request #5169: Table level timeout
implementation
URL: https://github.com/apache/incubator-pinot/pull/5169#discussion_r396729511
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -354,9 +359,12 @@ public synchronized void buildRouting(String
tableNameWithType) {
}
}
+ QueryConfig queryConfig = tableConfig.getQueryConfig();
+ Long timeoutMs = queryConfig != null ? queryConfig.getTimeoutMs() : null;
Review comment:
It should not be `0` (added a check), but `1ms` might be too long for broker
compilation to timeout. Let me revise the test, merge the broker & server
timeout so that test is not flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
