mcvsubbu commented on a change in pull request #5169: Table level timeout
implementation
URL: https://github.com/apache/incubator-pinot/pull/5169#discussion_r396724265
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BrokerUserDefinedMessageHandlerFactory.java
##########
@@ -98,15 +101,18 @@ public void onError(Exception e, ErrorCode errorCode,
ErrorType errorType) {
}
}
- private class QueryQuotaUpdateMessageHandler extends DefaultMessageHandler {
+ private class RefreshTableConfigMessageHandler extends MessageHandler {
+ final String _tableNameWithType;
- public QueryQuotaUpdateMessageHandler(QueryQuotaUpdateMessage
queryQuotaUpdateMessage,
- NotificationContext context) {
- super(queryQuotaUpdateMessage, context);
+ RefreshTableConfigMessageHandler(TableConfigRefreshMessage
tableConfigRefreshMessage, NotificationContext context) {
+ super(tableConfigRefreshMessage, context);
+ _tableNameWithType = tableConfigRefreshMessage.getTableNameWithType();
}
@Override
public HelixTaskResult handleMessage() {
+ // TODO: Fetch the table config here and pass it into the managers, or
consider merging these 2 managers
Review comment:
not sure why we should merge the 2 managers. Fetching table config, checking
for disabled table, etc. maybe yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
