mcvsubbu commented on a change in pull request #5169: Table level timeout
implementation
URL: https://github.com/apache/incubator-pinot/pull/5169#discussion_r396828878
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -185,6 +191,58 @@ public void testInvalidTableConfig() {
}
}
+ @Test
+ public void testRefreshTableConfigAndQueryTimeout()
+ throws Exception {
+ TableConfig tableConfig =
_helixResourceManager.getOfflineTableConfig(getTableName());
+ assertNotNull(tableConfig);
+
+ // Set timeout as 5ms so that query will timeout
+ tableConfig.setQueryConfig(new QueryConfig(5L));
+ _helixResourceManager.updateTableConfig(tableConfig);
+
+ // Wait for at most 1 minute for broker to receive and process the table
config refresh message
+ TestUtils.waitForCondition(aVoid -> {
Review comment:
seems like a candidate for intermittent failure, good to add a comment on
the circumstances under which this test can fail. I cant think of another way
to add the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
