jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397575889
########## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java ########## @@ -21,16 +21,17 @@ import com.google.common.annotations.VisibleForTesting; import com.yammer.metrics.core.MetricName; import com.yammer.metrics.core.MetricsRegistry; +import org.apache.pinot.common.Utils; Review comment: | Is this for real-time? We already have push type of either APPEND or REFRESH for offline; aggregateMetrics for real-time. What does UPSERT stand for? replied in earlier comment, basically design for supporting update/insert in pinot realtime ingestion ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
