ChethanUK commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r398153186
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ########## @@ -59,13 +65,28 @@ private static final Logger LOGGER = LoggerFactory.getLogger(Schema.class); private String _schemaName; + + // upsert related config + // primary key refers to the column name that is the primary key of this upsert table + private String _primaryKey; Review comment: > don't have support for multiple primary keys There will be some cases where multiple keys make sense right? Like in clickstream: `userId and timestamp` Will support for multiple keys be added later on? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
