Jackie-Jiang commented on a change in pull request #5177: Lucene DocId to
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400566628
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextIndexReader.java
##########
@@ -121,7 +131,7 @@ public MutableRoaringBitmap getDocIds(Object value) {
try {
Query query = _queryParser.parse(searchQuery);
_indexSearcher.search(query, docIDCollector);
- return getPinotDocIds(docIDs);
+ return getPinotDocIdsFromMappingFile(docIDs);
} catch (Exception e) {
LOGGER.error("Failed while searching the text index for column {},
search query {}, exception {}", _column,
Review comment:
You don't really need to log the error if you are going to throw out the
exception. The catcher will log it with the stack trace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
