siddharthteotia commented on a change in pull request #5177: Lucene DocId to
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400552298
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextIndexReader.java
##########
@@ -70,6 +76,10 @@ public LuceneTextIndexReader(String column, File
segmentIndexDir) {
// Disable Lucene query result cache. While it helps a lot with
performance for
// repeated queries, on the downside it cause heap issues.
_indexSearcher.setQueryCache(null);
+ // TODO: consider using a threshold of num docs per segment to decide
between building
+ // mapping file upfront on segment load v/s on-the-fly during query
processing
+ _docIdReaderWriter = new DocIdReaderWriter(segmentIndexDir, _column,
numDocs);
+ _docIdReaderWriter.buildDocIdMapping(numDocs);
Review comment:
We check for existence and return.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
