jihaozh commented on a change in pull request #5207: [TE] Retain the original last success task execution time if we can't… URL: https://github.com/apache/incubator-pinot/pull/5207#discussion_r402536249
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/health/DetectionTaskStatus.java ########## @@ -46,10 +46,14 @@ // the time stamp of last successfully finishing task @JsonProperty - private final Long lastTaskExecutionTime; + private Long lastSuccessTaskExecutionTime; Review comment: We may need to keep the name, otherwise, the existing JSON blobs in the DB won't be able to deserialize back to the object. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
