xiaohui-sun commented on a change in pull request #5207: [TE] Retain the
original last success task execution time if we can't…
URL: https://github.com/apache/incubator-pinot/pull/5207#discussion_r403642882
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java
##########
@@ -162,6 +162,12 @@ public DetectionHealth getHealth() {
}
public void setHealth(DetectionHealth health) {
+ // If there is no success execution in the current window then the last
success task execution time would be -1L.
+ // We should keep the original last success task execution time if we have.
+ long lastSuccessTaskExecutionTime =
this.health.getDetectionTaskStatus().getLastSuccessTaskExecutionTime();
Review comment:
Makes sense! I changed that. Can you review again? @jihaozh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
