Jackie-Jiang commented on a change in pull request #5238: Evaluate schema transform expressions during ingestion URL: https://github.com/apache/incubator-pinot/pull/5238#discussion_r407685246
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/function/evaluators/GroovyExpressionEvaluator.java ########## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data.function.evaluators; + +import com.google.common.base.Splitter; +import groovy.lang.Binding; +import groovy.lang.GroovyShell; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.pinot.spi.data.readers.GenericRow; + + +/** + * An {@link ExpressionEvaluator} for evaluating schema transform expressions written in Groovy. + * GroovyShell is used to execute expressions. + * + * The transform expression must follow the convention Groovy({expression}, arguments1, argument2...) + * For example: + * "dimensionFieldSpecs": [ + * { + * "name": "fullName", + * "dataType": "STRING", + * "transformFunction": "Groovy({firstName+' '+lastName}, firstName, lastName)" + * } + * ] + */ +public class GroovyExpressionEvaluator implements ExpressionEvaluator { + + private static final String GROOVY_EXPRESSION_PREFIX = "Groovy"; + private static final String GROOVY_FUNCTION_REGEX = "Groovy\\(\\{(?<script>.+)}(,(?<arguments>.+))?\\)"; + private static final Pattern GROOVY_FUNCTION_PATTERN = Pattern.compile(GROOVY_FUNCTION_REGEX, Pattern.CASE_INSENSITIVE); + private static final String ARGUMENTS_GROUP_NAME = "arguments"; + private static final String SCRIPT_GROUP_NAME = "script"; + private static final String ARGUMENTS_SEPARATOR = ","; + + private List<String> _arguments; + private String _script; + + public GroovyExpressionEvaluator(String transformExpression) { + Matcher matcher = GROOVY_FUNCTION_PATTERN.matcher(transformExpression); + if (matcher.matches()) { + _script = matcher.group(SCRIPT_GROUP_NAME); + + String arguments = matcher.group(ARGUMENTS_GROUP_NAME); + if (arguments != null) { + _arguments = Splitter.on(ARGUMENTS_SEPARATOR).trimResults().splitToList(arguments); + } else { + _arguments = Collections.emptyList(); + } + } + } + + public static String getGroovyExpressionPrefix() { + return GROOVY_EXPRESSION_PREFIX; + } + + @Override + public List<String> getArguments() { + return _arguments; + } + + @Override + public Object evaluate(GenericRow genericRow) { + Map<String, Object> params = new HashMap<>(); + for (String argument : _arguments) { + params.put(argument, genericRow.getValue(argument)); + } + if (params.containsValue(null)) { // TODO: disallow evaluation of any of the params is null? Or give complete control to function? Review comment: For better performance, check it at line 86 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
