Jackie-Jiang commented on a change in pull request #5238: Evaluate schema
transform expressions during ingestion
URL: https://github.com/apache/incubator-pinot/pull/5238#discussion_r407662643
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/CompositeTransformer.java
##########
@@ -48,9 +47,11 @@
* </ul>
*/
public static CompositeTransformer getDefaultTransformer(Schema schema) {
+ // TODO: ExpressionTransformer contains record with source columns, and
after transformation, the record has source + destination columns.
Review comment:
Should be okay as we only extract the needed columns, then we can reuse the
record
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
