npawar commented on a change in pull request #5238: Evaluate schema transform expressions during ingestion URL: https://github.com/apache/incubator-pinot/pull/5238#discussion_r408516198
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/function/evaluators/DefaultTimeSpecEvaluator.java ########## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data.function.evaluators; + +import com.google.common.base.Preconditions; +import com.google.common.collect.Lists; +import java.util.List; +import org.apache.pinot.spi.data.TimeFieldSpec; +import org.apache.pinot.spi.data.TimeGranularitySpec; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.utils.TimeConverter; +import org.apache.pinot.spi.utils.TimeUtils; + + +/** + * The {@code DefaultTimeSpecEvaluator} class will convert the time value based on the {@link TimeFieldSpec}. + */ +public class DefaultTimeSpecEvaluator implements ExpressionEvaluator { + private String _incomingTimeColumn; + private String _outgoingTimeColumn; + private TimeConverter _incomingTimeConverter; + private TimeConverter _outgoingTimeConverter; + private boolean _isValidated = false; + + public DefaultTimeSpecEvaluator(TimeGranularitySpec incomingGranularitySpec, + TimeGranularitySpec outgoingGranularitySpec) { + Preconditions.checkState(!incomingGranularitySpec.equals(outgoingGranularitySpec)); + _incomingTimeColumn = incomingGranularitySpec.getName(); + _outgoingTimeColumn = outgoingGranularitySpec.getName(); + Preconditions.checkState(!_incomingTimeColumn.equals(_outgoingTimeColumn)); + _incomingTimeConverter = new TimeConverter(incomingGranularitySpec); + _outgoingTimeConverter = new TimeConverter(outgoingGranularitySpec); + } + + @Override + public List<String> getArguments() { + return Lists.newArrayList(_incomingTimeColumn, _outgoingTimeColumn); Review comment: Based on offline discussion, added support for case where transformed destination field already exists in the data. DefaultTimeSpecEvaluator looks right now i.e. only incoming in getArguments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
