Jackie-Jiang commented on a change in pull request #5238: Evaluate schema 
transform expressions during ingestion
URL: https://github.com/apache/incubator-pinot/pull/5238#discussion_r408533504
 
 

 ##########
 File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordExtractor.java
 ##########
 @@ -18,16 +18,29 @@
  */
 package org.apache.pinot.spi.data.readers;
 
-import org.apache.pinot.spi.data.Schema;
+import java.util.List;
 
+
+/**
+ * Extracts fields from input records
+ * @param <T> The format of the input record
+ */
 public interface RecordExtractor<T> {
+
+  /**
+   * Initialize the record extractor with its config
+   *
+   * @param fields List of field names to extract from the provided input 
record
+   * @param recordExtractorConfig The record extractor config
+   */
+  void init(List<String> fields, RecordExtractorConfig recordExtractorConfig);
 
 Review comment:
   This should also take a set

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to