mayankshriv opened a new pull request #5259: Support Aggregation functions with multiple arguments. URL: https://github.com/apache/incubator-pinot/pull/5259 The current implementation assumes that all AggregationFunctions take one argument with the exception of DistinctAggregationFunction. This PR handles changes related to supporting AggregationFunctions with multiple arguments, as we anticipate new aggregation functions to be added that take multiple arguments. 1. Enhanced parser to allow multiple arguments for aggregation functions. 2. AggregationFunctionFactory provides the right set of arguments when instantiating individual aggregation functions. 3. AggregationFunctions now store their arguments, as opposed to assuming that the right BlockValSet is passed to the aggregate() api's. 4. AggregationFunction.aggregate() api's now take a Map<String, BlockValSet> where the key is the argument expression (columnName for simple case), as opposed to a variable array as that interface does not provide a way to associate BlockValSet with the argument. 5. Cleanup: Removed env variable to enable/disable Distinct, as there is no need for it to be disabled anymore.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
