kishoreg commented on a change in pull request #5259: Support Aggregation
functions with multiple arguments.
URL: https://github.com/apache/incubator-pinot/pull/5259#discussion_r409261121
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java
##########
@@ -121,7 +121,8 @@ private void convertSelectList(PinotQuery pinotQuery,
BrokerRequest brokerReques
List<AggregationInfo> aggregationInfoList = null;
for (Expression expression : pinotQuery.getSelectList()) {
ExpressionType type = expression.getType();
- if (type == ExpressionType.FUNCTION &&
expression.getFunctionCall().getOperator().equalsIgnoreCase(SqlKind.AS.toString()))
{
+ if (type == ExpressionType.FUNCTION &&
expression.getFunctionCall().getOperator()
Review comment:
I dint see the use of SQLKind here, we don't want to leak this. Can you
please move this constant to PinotQuery.Constants or some other place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
