mayankshriv commented on a change in pull request #5259: Support Aggregation
functions with multiple arguments.
URL: https://github.com/apache/incubator-pinot/pull/5259#discussion_r409307572
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##########
@@ -42,79 +47,87 @@ private AggregationFunctionFactory() {
public static AggregationFunction getAggregationFunction(AggregationInfo
aggregationInfo,
@Nullable BrokerRequest brokerRequest) {
String functionName = aggregationInfo.getAggregationType();
+ String argumentsString =
AggregationFunctionUtils.getColumn(aggregationInfo);
Review comment:
This is for passing multiple args as one concatenated string in this PR, to
avoid backward incompatible change in request.thrift for AggregationInfo. Open
to suggestions if there is a trivial fix here that can be done in this PR.
Otherwise, will address it separately in a backward compatible way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
